chore: enable PMD GuardLogStatement rule#1284
Draft
joaodinissf wants to merge 5 commits intodsldevkit:masterfrom
Draft
chore: enable PMD GuardLogStatement rule#1284joaodinissf wants to merge 5 commits intodsldevkit:masterfrom
joaodinissf wants to merge 5 commits intodsldevkit:masterfrom
Conversation
joaodinissf
force-pushed
the
chore/pmd-todo-cleanup
branch
4 times, most recently
from
552a8ad to
f9540a3
Compare
joaodinissf
changed the title
Replace string concatenation, NLS.bind, and MessageFormat.format in
log calls with parameterized {} placeholders. Use Supplier/method-refs
for lazy argument evaluation where appropriate.
Modules: check.core.test, check.runtime.core, check.runtime.ui,
check.ui, checkcfg.core
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace string concatenation with parameterized {} placeholders.
Use Supplier lambdas for lazy argument evaluation. Add NOPMD
suppressions for SLF4J logger calls (SwtBot uses SLF4J, not Log4j).
Add org.apache.logging.log4j.util to OSGi manifests for Supplier.
Modules: test.core, test.ui
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace string concatenation, NLS.bind, and MessageFormat.format in
log calls with parameterized {} placeholders. Use Supplier/method-refs
for lazy argument evaluation. Extract duplicate format strings to
constants. Add org.apache.logging.log4j.util to OSGi manifest.
Modules: xtext, typesystem
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…enerator/UI
Replace string concatenation and NLS.bind in log calls with
parameterized {} placeholders. Use Supplier/method-refs for lazy
argument evaluation. Add NOPMD suppressions for ITraceSet.trace()
and Supplier method-refs not recognized by PMD. Add
org.apache.logging.log4j.util to OSGi manifests.
Modules: xtext.builder, xtext.expression, xtext.generator,
xtext.ui, xtext.test.core
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove the GuardLogStatement exclusion and configure the rule for debug/trace levels. Also replace bare TODO comments on remaining excluded rules (PreserveStackTrace, UseTryWithResources) with actionable descriptions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
chore/pmd-todo-cleanup
branch
from
f9540a3 to
8ce505d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1307
Summary
Enable the
GuardLogStatementPMD rule for debug/trace levels, and clean up remaining TODO comments in the PMD ruleset.Test plan
mvn compile pmd:pmd pmd:checkpasses with no violations🤖 Generated with Claude Code